a11y: Set focus-related states properly

Entries and menubuttons are no longer focusable themselves,
they have focusable children. Since we don't have accessible
objects for those, transfer the focus-related state (focusable
and focused) from the children to the main accessible object.

diff --git a/gtk/a11y/gtkentryaccessible.c b/gtk/a11y/gtkentryaccessible.c
index 3a229bb94dd9556bc7243ebc51834411fc6433cb..01bd1c9ac2a8785b1682ce9e481012b90dab7f6a 100644 (file)
--- a/gtk/a11y/gtkentryaccessible.c
+++ b/gtk/a11y/gtkentryaccessible.c
@@ -387,13 +387,20 @@ gtk_entry_accessible_ref_state_set (AtkObject *accessible)
   AtkStateSet *state_set;
   gboolean value;
   GtkWidget *widget;
+  GtkWidget *text;
 
   widget = gtk_accessible_get_widget (GTK_ACCESSIBLE (accessible));
   if (widget == NULL)
     return NULL;
 
+  text = gtk_widget_get_first_child (widget);
+
   state_set = ATK_OBJECT_CLASS (gtk_entry_accessible_parent_class)->ref_state_set (accessible);
 
+  atk_state_set_add_state (state_set, ATK_STATE_FOCUSABLE);
+  if (gtk_widget_has_focus (text))
+    atk_state_set_add_state (state_set, ATK_STATE_FOCUSED);
+
   g_object_get (G_OBJECT (widget), "editable", &value, NULL);
   if (value)
     atk_state_set_add_state (state_set, ATK_STATE_EDITABLE);

diff --git a/gtk/a11y/gtkmenubuttonaccessible.c b/gtk/a11y/gtkmenubuttonaccessible.c
index 17ae8be002d251336198a6439e6fee5928c22ee5..75482cfc218874cbe0fcf807fe6233a18f074bf7 100644 (file)
--- a/gtk/a11y/gtkmenubuttonaccessible.c
+++ b/gtk/a11y/gtkmenubuttonaccessible.c
@@ -77,6 +77,28 @@ gtk_menu_button_accessible_get_name (AtkObject *obj)
   return _("Menu");
 }
 
+static AtkStateSet *
+gtk_menu_button_accessible_ref_state_set (AtkObject *obj)
+{
+  AtkStateSet *state_set;
+  GtkWidget *widget;
+  GtkWidget *button;
+
+  widget = gtk_accessible_get_widget (GTK_ACCESSIBLE (obj));
+  if (widget == NULL)
+    return NULL;
+
+  button = gtk_widget_get_first_child (widget);
+
+  state_set = ATK_OBJECT_CLASS (gtk_menu_button_accessible_parent_class)->ref_state_set (obj);
+
+  atk_state_set_add_state (state_set, ATK_STATE_FOCUSABLE);
+  if (gtk_widget_has_focus (button))
+    atk_state_set_add_state (state_set, ATK_STATE_FOCUSED);
+
+  return state_set;
+}
+
 static void
 gtk_menu_button_accessible_class_init (GtkMenuButtonAccessibleClass *klass)
 {
@@ -86,6 +108,7 @@ gtk_menu_button_accessible_class_init (GtkMenuButtonAccessibleClass *klass)
   class->initialize = gtk_menu_button_accessible_initialize;
   class->get_n_children = gtk_menu_button_accessible_get_n_children;
   class->ref_child = gtk_menu_button_accessible_ref_child;
+  class->ref_state_set = gtk_menu_button_accessible_ref_state_set;
 }
 
 static void